Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code simplification #230

Merged
merged 1 commit into from
Oct 25, 2023
Merged

code simplification #230

merged 1 commit into from
Oct 25, 2023

Conversation

adrelanos
Copy link
Contributor

Remove unnecessary use of eend 0.

fixes #229

@mika
Copy link
Member

mika commented Oct 25, 2023

Ah, nice catch, thanks! That seems to be a leftover from c87dc4a.

nitpick: please slightly improve the commit message, the code simplification in the first line would show up as such in debian/changelog and doesn't tell much :)

So I'd propose something like:

code simplification: drop NOP usage of eend 0

Remove unnecessary use of `eend 0`, which does effectively nothing.
Leftover from git rev c87dc4ae where we moved from grml-etc-core's
lsb-functions functions to a simplified version of them.
    
Closes: https://github.com/grml/grml-debootstrap/issues/229

(Let me know if you'd prefer me to take care of it)

Remove unnecessary use of `eend 0`, which does effectively nothing.
Leftover from git rev c87dc4a where we moved from grml-etc-core's
lsb-functions functions to a simplified version of them.

Closes: #229
@adrelanos
Copy link
Contributor Author

Commit message updated.

I couldn't have invented that commit message myself. :)

@mika mika merged commit d911a37 into grml:master Oct 25, 2023
@mika
Copy link
Member

mika commented Oct 25, 2023

Commit message updated.

Great, thanks! Merged!

I couldn't have invented that commit message myself. :)

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eend 0 does effectively nothing, so let's remove it
2 participants